Re: [PATCHES] vcbuild optional packages

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Marko Kreen <markokr(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PGSQL-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] vcbuild optional packages
Date: 2007-01-14 20:55:43
Message-ID: 20070114205543.GE7233@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Marko Kreen wrote:
> On 1/14/07, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> >Is there any reason why the check is "backwards" in pgcrypto compared to
> >the rest of the system? All the other places check for HAVE_ZLIB from
> >what I can tell.
>
> Eh, just an oversight from my part. I was so focused on Makefile
> hacking so I forgot to check if there is already a define
> somewhere. And its reverse to have less clutter in command-line
> in default case.
>
> Attached patch replaces unnecessary DISABLE_ZLIB define in
> pgcrypto with HAVE_LIBZ from core. Result is bit simpler
> Makefile which is only good.

Applied.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2007-01-14 20:57:45 Re: Autovacuum improvements
Previous Message Alvaro Herrera 2007-01-14 20:27:19 Re: Autovacuum improvements

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2007-01-14 20:57:45 Re: Autovacuum improvements
Previous Message Alvaro Herrera 2007-01-14 20:27:19 Re: Autovacuum improvements