Re: [HACKERS] [PATCHES] Patch to log usage of temporary files

From: "Jim C(dot) Nasby" <jim(at)nasby(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Bill Moran <wmoran(at)collaborativefusion(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] [PATCHES] Patch to log usage of temporary files
Date: 2007-01-11 21:09:44
Message-ID: 20070111210944.GS36267@nasby.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Thu, Jan 11, 2007 at 12:35:25PM -0500, Tom Lane wrote:
> I think the real criterion has to be "is this probe useful to
> developers?". I'm entirely uninterested in adding probes that are
> targeted towards DBAs, as this one would have been --- if we think
> there's a problem that a DBA would have, we need to offer a more
> portable solution than that. Which we did, in the form of a logging
> option, which makes the DTrace probe pretty useless anyway.

But the problem with just logging stuff is it's not a monitoring
solution. Granted, it's better than nothing, but in a production
environment I'd like to have some way to monitor temp file
usage/utilization over time. AFAIK dtrace would provide that capability,
thought I don't think it'd be unreasonable to have our own counter as
well. Perhaps add temp_usage_count and temp_usage_size to
pg_stat_database (number of times something spilled to disk and total
size, respectively).
--
Jim Nasby jim(at)nasby(dot)net
EnterpriseDB http://enterprisedb.com 512.569.9461 (cell)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-01-11 21:11:40 Re: [HACKERS] unusual performance for vac following 8.2 upgrade
Previous Message Tom Lane 2007-01-11 21:03:55 Some notes about redesigning planner data structures

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-01-11 21:36:11 vcbuild - conditional regeneration
Previous Message Albert Cervera Areny 2007-01-11 20:02:02 Re: [PATCHES] Tablespace for temporary objects and sort files