Re: pgsql: Change Windows rename and unlink

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: pgsql-hackers(at)postgresql(dot)org, tgl(at)postgresql(dot)org
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Change Windows rename and unlink
Date: 2007-01-10 10:22:31
Message-ID: 20070110.192231.126778923.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Is there any reason for not back porting the fix into 8.1?
--
Tatsuo Ishii
SRA OSS, Inc. Japan

> Log Message:
> -----------
> Change Windows rename and unlink substitutes so that they time out after
> 30 seconds instead of retrying forever. Also modify xlog.c so that if
> it fails to rename an old xlog segment up to a future slot, it will
> unlink the segment instead. Per discussion of bug #2712, in which it
> became apparent that Windows can handle unlinking a file that's being
> held open, but not renaming it.
>
> Modified Files:
> --------------
> pgsql/src/backend/access/transam:
> xlog.c (r1.253 -> r1.254)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c.diff?r1=1.253&r2=1.254)
> pgsql/src/port:
> dirmod.c (r1.43 -> r1.44)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/port/dirmod.c.diff?r1=1.43&r2=1.44)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster
>

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-01-10 14:17:19 Re: pgsql: Change Windows rename and unlink substitutes so that they time
Previous Message Tatsuo Ishii 2007-01-10 10:21:34 Re: [COMMITTERS] pgsql: Change Windows rename and unlink

Browse pgsql-hackers by date

  From Date Subject
Next Message Teodor Sigaev 2007-01-10 10:27:03 Re: Request for review: tsearch2 patch
Previous Message Tatsuo Ishii 2007-01-10 10:21:34 Re: [COMMITTERS] pgsql: Change Windows rename and unlink