Re: [HACKERS] Patch to log usage of temporary files

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bill Moran <wmoran(at)collaborativefusion(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch to log usage of temporary files
Date: 2007-01-09 22:37:40
Message-ID: 200701092237.l09MbeK25291@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bill Moran <wmoran(at)collaborativefusion(dot)com> writes:
> > In response to Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> >> and then zero
> >> can be the "off" position, and we need not worry about whether -1 is
> >> -1 byte or -1 kbyte.
>
> > All doing this does is make it impossible to log temp files of 1 byte.
>
> How you figure that? It would make it impossible to log files of *zero*
> bytes, if anyone cared about that, but not 1 byte. 1 byte > 0 kbyte.

Uh, if you supply just a number with no units, is that bytes or
kilobytes? Do you have to say "0B".

Even if we could get that to work, I don't think it is worth the
inconsistency with the other GUC entries to do it. The units are
mentioned in the comments in postgresql.conf.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-01-09 22:40:14 Re: [HACKERS] Last infomask bit
Previous Message Tom Lane 2007-01-09 22:36:41 Re: [HACKERS] Patch to log usage of temporary files

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-01-09 22:40:14 Re: [HACKERS] Last infomask bit
Previous Message Tom Lane 2007-01-09 22:36:41 Re: [HACKERS] Patch to log usage of temporary files