Re: [COMMITTERS] pgsql: Check for ERANGE in exp()

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
Cc: Bruce Momjian <momjian(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Check for ERANGE in exp()
Date: 2007-01-06 20:20:46
Message-ID: 200701062020.l06KKkC22255@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Stefan Kaltenbrunner wrote:
> Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Check for ERANGE in exp() as well.
>
> this broke the regression tests on a number of boxes:
>
> http://buildfarm.postgresql.org/cgi-bin/show_status.pl
>
> example:
>
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sponge&dt=2007-01-06%2015:30:02

Thanks. This is something I wanted to ask Tom about today. I was
worried that ERANGE could be generated by underflow as well as overflow,
and setting result to Inf would not work for underflow. I have applied
the following patch to test for != 0 and != Inf, which should elimintate
the underflow case.

Tom, on HPPA, does ERANGE get set for both overflow and underflow? I
assume only overflow.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/bjm/diff text/x-diff 1.2 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2007-01-06 20:21:29 pgsql: Apply fix so pow() and exp() ERANGE is used only if result is not
Previous Message Stefan Kaltenbrunner 2007-01-06 20:07:28 Re: [COMMITTERS] pgsql: Check for ERANGE in exp() as well.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-01-06 20:24:02 Re: COPY with no WAL, in certain circumstances
Previous Message Tom Lane 2007-01-06 20:07:47 Re: Parsing ambiguity for ORDER BY ... NULLS FIRST/LAST