pgsql: Fix mishandling of after-trigger state when a SQL function

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix mishandling of after-trigger state when a SQL function
Date: 2006-10-12 17:02:24
Message-ID: 20061012170224.6823B9FB3B6@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix mishandling of after-trigger state when a SQL function returns multiple
rows --- if the surrounding query queued any trigger events between the rows,
the events would be fired at the wrong time, leading to bizarre behavior.
Per report from Merlin Moncure.

This is a simple patch that should solve the problem fully in the back
branches, but in HEAD we also need to consider the possibility of queries
with RETURNING clauses. Will look into a fix for that separately.

Modified Files:
--------------
pgsql/src/backend/executor:
functions.c (r1.107 -> r1.108)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/functions.c.diff?r1=1.107&r2=1.108)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-10-12 17:02:28 pgsql: Fix mishandling of after-trigger state when a SQL function
Previous Message Tom Lane 2006-10-12 15:04:55 pgsql: Use Min() instead of min() in qsort, for consistency and to avoid