| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Oliver Artelt <oli(at)cubeoffice(dot)de>, pgsql-bugs(at)postgresql(dot)org, Magnus Hagander <mha(at)sollentuna(dot)net> |
| Subject: | Re: BUG #2665: VC++ 8 (Visual Studio 2005) |
| Date: | 2006-10-03 03:58:35 |
| Message-ID: | 200610030358.k933wZ018843@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Uh, I think we still do have reasons to test if we are using MSVC or
> > Borland C. I think the #define should just be moved up in c.h.
>
> Current evidence says otherwise --- but if you insist, why not put the
> define in win32.h in the first place, instead of cluttering c.h with it?
Well, we certainly need the define for the __inline macro, because was
reported as the bug.
I moved the define to win32.h as you suggested, attached, applied.
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| Attachment | Content-Type | Size |
|---|---|---|
| /bjm/diff | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Toru SHIMOGAKI | 2006-10-03 14:35:34 | BUG #2671: incorrect return value by RULE |
| Previous Message | Tom Lane | 2006-10-03 02:51:05 | Re: BUG #2665: VC++ 8 (Visual Studio 2005) |