Re: BUG #2665: VC++ 8 (Visual Studio 2005)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Oliver Artelt <oli(at)cubeoffice(dot)de>, pgsql-bugs(at)postgresql(dot)org, Magnus Hagander <mha(at)sollentuna(dot)net>
Subject: Re: BUG #2665: VC++ 8 (Visual Studio 2005)
Date: 2006-10-03 02:13:37
Message-ID: 200610030213.k932Dbo05650@momjian.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Interesting. We have inline redefined in src/include/port/win32.h. Can
> > you find out why you are not getting those redefined?
>
> AFAICS, all the "#ifdef WIN32_ONLY_COMPILER" code in win32.h is dead
> code, because c.h doesn't #define WIN32_ONLY_COMPILER until *after* it's
> included pg_config_os.h. It would appear that most of it is indeed
> useless and should be removed.

Uh, I think we still do have reasons to test if we are using MSVC or
Borland C. I think the #define should just be moved up in c.h.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2006-10-03 02:51:05 Re: BUG #2665: VC++ 8 (Visual Studio 2005)
Previous Message Tom Lane 2006-10-03 01:32:35 Re: BUG #2665: VC++ 8 (Visual Studio 2005)