Re: Getting a move on for 8.2 beta

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Getting a move on for 8.2 beta
Date: 2006-09-04 17:51:21
Message-ID: 200609041951.22400.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> How many times do I have to say this: IT IS NOT A REFACTOR PATCH AS
> REPORTED BY THE AUTHOR, AND PETER HAS NOT REFUTED THAT.

The initial patch was the feature plus some code refactoring included.
That was what the author said. I asked him to submit the refactoring
and the feature as two separate patches. What I got was a refactoring
subpatch that actually made the code longer in terms of lines, which
must be the very first code refactoring ever to achieve that. I did
not get a satisfying answer on why that has to be, so I sort of lost
interest in working with that patch.

That does not mean that the patch is bad, and I certainly support the
feature change. But I can't efficiently review the patch. If someone
else wants to do it, go ahead.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-09-04 17:51:40 Re: [PATCHES] Contrib module to examine client
Previous Message Peter Eisentraut 2006-09-04 17:41:27 Re: [COMMITTERS] pgsql: sslinfo contrib module - information about current SSL