Re: [HACKERS] Custom variable class segmentation

Where are we on the GUC comment/reload to defaults patch? Do we have
multiple people objecting to its application? Previously only Tom
objected, and Andrew partially.

---------------------------------------------------------------------------

Bruce Momjian wrote:
> Tom Lane wrote:
> > Michael Fuhr <mike(at)fuhr(dot)org> writes:
> > > The latest HEAD is segfaulting on startup if I have the following
> > > lines in postgresql.conf:
> >
> > > custom_variable_classes = 'plperl'
> > > plperl.use_strict = on
> >
> > Bruce, please re-revert that GUC patch and don't put it back in until
> > someone like Peter or me has actually reviewed it. My faith in it has
> > gone to zero, and I don't think you are able to fix it either.
>
> Peter had already reviewed it and given comments.
>
> There were three things wrong with the original patch:
>
> o spacing, e.g. "if( x =- 1 )"
> o an incorrect API for memory freeing by parse_value()
> o verify_config_option() didn't consider custom variables
>
> These have all been corrected, so I don't see the value in removing the
> patch now that it is working. I have attached the three GUC patches
> that were applied to CVS, so if someone wants corrections or removal
> based on specific issues, please let me know.
>
> > BTW, do I need to mention that the plperl patch is breaking the
> > buildfarm again?
>
> That has been reverted, because of the regression failures and Andrew's
> analysis.
>
> --
> Bruce Momjian bruce(at)momjian(dot)us
> EnterpriseDB http://www.enterprisedb.com
>
> + If your life is a hard drive, Christ can be your backup. +

>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
> choose an index scan if your joining column's datatypes do not
> match

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +