| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Zoltan Boszormenyi <zboszor(at)dunaweb(dot)hu> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] COPY view |
| Date: | 2006-08-23 17:35:29 |
| Message-ID: | 20060823173529.GV1963@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Zoltan Boszormenyi wrote:
> 1. to minimize the already huge code impact on the relation case.
> 2. the checks done for the SELECT case is not exactly the
> same as for the realation case.
So put them in CopyToRelation. But the ones that apply to both, leave
in CopyTo.
> 3. the relation case is managed by passing around
> a Relation pointer, e.g. CopyGetAttnums. This simply
> not appropriate for the SELECT case.
Which is why you should leave the relation case alone and only add the
different case. The relation case is already known to be good.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-08-23 17:48:15 | Re: [PATCHES] COPY view |
| Previous Message | Merlin Moncure | 2006-08-23 17:33:51 | Re: Win32 max connections bug (causing crashes) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-08-23 17:48:15 | Re: [PATCHES] COPY view |
| Previous Message | Zoltan Boszormenyi | 2006-08-23 17:28:37 | Re: [PATCHES] COPY view |