Re: segfault on rollback

From: "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: segfault on rollback
Date: 2006-08-14 15:30:47
Message-ID: 20060814153047.GE27928@pervasive.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Aug 13, 2006 at 07:01:13PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Tom Lane wrote:
> >> This reminds me that even though the V3-protocol code has been in there
> >> since 7.4, we don't have nearly complete test coverage on it. It'd be a
> >> good idea to have some basic tests included somewhere in the standard or
> >> contrib regression tests. Any thoughts about an easy way to do it?
>
> > Do we have anything on core which speaks the v3 protocol? Since libpq
> > doesn't expose functions to do all the stuff the v3 protocol can do, it
> > would be difficult.
>
> libpq doesn't expose everything in v3, but it exposes quite a lot ---
> and will expose more once the Describe patch gets in. I think the main
> thing you still can't do is issue a Bind as a separate operation from an
> Execute, and that's not something I feel is real important for testing
> the backend. The main problem is to have something that actually calls
> the V3-protocol functions, which psql doesn't.
>
> I was thinking of suggesting that even making psql use PQexecParams
> instead of PQexec would help for testing purposes. But from a raw
> performance point of view that's probably a loss; also it would be the
> final blow to using a modern psql to connect to a pre-7.4 server.

How much cruft would it add to psql to allow use of V3 as an option?
Presumably no one would use it in real life, but it would make it easier
to test things. If it's not too invasive to psql it'd be a win to go
that route over adding extra code just to test V3.
--
Jim C. Nasby, Sr. Engineering Consultant jnasby(at)pervasive(dot)com
Pervasive Software http://pervasive.com work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf cell: 512-569-9461

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2006-08-14 16:09:23 Re: I am away Monday to Friday
Previous Message Jim C. Nasby 2006-08-14 15:27:43 Re: problem with volatile functions in subselects ?