pgsql: Remove hash_destroy calls in hash_create's failure paths.

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove hash_destroy calls in hash_create's failure paths.
Date: 2006-08-14 12:39:56
Message-ID: 20060814123956.1A9489FB223@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Remove hash_destroy calls in hash_create's failure paths. As noted by
a Coverity warning, these are risky since the hashtable isn't necessarily
fully set up yet. They're unnecessary anyway: a deletable hashtable
should be in a memory context that will be cleared following elog(ERROR).
Per report from Martijn van Oosterhout.

Modified Files:
--------------
pgsql/src/backend/utils/hash:
dynahash.c (r1.70 -> r1.71)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/hash/dynahash.c.diff?r1=1.70&r2=1.71)

Browse pgsql-committers by date

  From Date Subject
Next Message User Korryd 2006-08-14 13:40:10 edb-debugger - workstation: Hiroshi-san's second patch (correcting my
Previous Message User Knt 2006-08-14 12:20:07 plscheme - plscheme: README file imported.