| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: segfault on rollback |
| Date: | 2006-08-13 22:36:03 |
| Message-ID: | 20060813223603.GB14441@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> I wrote:
> > We could "fix" this by emitting the log message before calling
> > finish_xact_command, but I think that would result in seriously
> > underreporting the time required for a COMMIT. Probably the right fix
> > is to copy the data we might need out of the Portal before committing.
>
> Patch applied.
>
> This reminds me that even though the V3-protocol code has been in there
> since 7.4, we don't have nearly complete test coverage on it. It'd be a
> good idea to have some basic tests included somewhere in the standard or
> contrib regression tests. Any thoughts about an easy way to do it?
Do we have anything on core which speaks the v3 protocol? Since libpq
doesn't expose functions to do all the stuff the v3 protocol can do, it
would be difficult. Maybe the Python project on pgFoundry (I don't
think it uses libpq, does it?), or maybe JDBC, can help here.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-08-13 22:37:04 | Re: [PATCHES] Adding fulldisjunctions to the contrib |
| Previous Message | Tom Lane | 2006-08-13 22:28:16 | Re: segfault on rollback |