From: | momjian(at)postgresql(dot)org (Bruce Momjian) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Refactor GUC set_config_option function: The main reason for |
Date: | 2006-08-11 20:08:28 |
Message-ID: | 20060811200828.CA9BD9FB1E6@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Refactor GUC set_config_option function:
The main reason for refactoring was that set_config_option() was too
overloaded function and its behavior did not consistent. Old version of
set_config_function hides some messages. For example if you type:
tcp_port = 5432.1
then old implementation ignore this error without any message to log
file in the signal context (configuration reload). Main problem was that
semantic analysis of postgresql.conf is not perform in the
ProcessConfigFile function, but in the set_config_options *after*
context check. This skipped check for variables with PG_POSTMASTER
context. There was request from Joachim Wieland to add more messages
about ignored changes in the config file as well.
Zdenek Kotala
Modified Files:
--------------
pgsql/src/backend/utils/misc:
guc-file.l (r1.38 -> r1.39)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc-file.l.diff?r1=1.38&r2=1.39)
guc.c (r1.333 -> r1.334)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c.diff?r1=1.333&r2=1.334)
pgsql/src/include/utils:
guc.h (r1.71 -> r1.72)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/guc.h.diff?r1=1.71&r2=1.72)
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2006-08-11 20:15:16 | pgsql: Allow commenting of variables in postgresql.conf to restore them |
Previous Message | Bruce Momjian | 2006-08-11 19:42:35 | pgsql: plperl: Allow conversion from perl to postgresql array in OUT |