Re: PGStatement#setPrepareThreshold

From: Bruce Momjian <bruce(at)momjian(dot)us>
To:
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dave Cramer <pg(at)fastcrypt(dot)com>, Oliver Jowett <oliver(at)opencloud(dot)com>, Csaba Nagy <nagy(at)ecircle-ag(dot)com>, Postgres JDBC <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: PGStatement#setPrepareThreshold
Date: 2006-08-04 18:56:53
Message-ID: 200608041856.k74IurK20224@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc pgsql-patches

bruce wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > Dave Cramer wrote:
> > >> Bind also has a statement name, as well as a portal name ?
> > >>
> > >> Ideally I'd like to see the parameters which were bound and the
> > >> types, but I suspect I'm reaching here.
> >
> > > Right, but do we want to repeat the statement for every bind case?
> >
> > My upthread proposal was to print the statement and portal names
> > at bind time. The current printout is very clearly inadequate.
>
> Sure, I can do that.
>
> Did you like my idea of?
>
> statement: <protocol execute> ...
>
> You didn't reply. I want to keep the "statement:" prefix for scripts
> that process our log files, and because it is output by log_statement,
> which controls protocol output as well.

I have applied this patch to output the statemented referenced by BIND.
I also changed the "[protocol]" string to "<protocol>" for clarity. I
am ready to pull PREPARE|BIND|EXECUTED into the "protocol" bracket too
if someone says that is a good idea.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/bjm/diff text/x-diff 3.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonah H. Harris 2006-08-04 19:00:24 Re: 8.2 features status
Previous Message Tom Lane 2006-08-04 18:40:30 "Constraint exclusion" is not general enough

Browse pgsql-jdbc by date

  From Date Subject
Next Message Tom Lane 2006-08-04 19:15:43 Re: PGStatement#setPrepareThreshold
Previous Message Kris Jurka 2006-08-04 17:42:53 Re: PGStatement#setPrepareThreshold

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-08-04 18:58:40 Re: patch of libpq-int.h is required of msvc.
Previous Message Hiroshi Saito 2006-08-04 18:52:28 patch of libpq-int.h is required of msvc.