| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] pg_regress breaks on msys |
| Date: | 2006-07-28 19:31:58 |
| Message-ID: | 200607281931.k6SJVw901030@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > *** src/test/regress/pg_regress.c 27 Jul 2006 15:37:19 -0000 1.16
> > --- src/test/regress/pg_regress.c 28 Jul 2006 19:01:12 -0000
> > ***************
> > *** 813,823 ****
> > * work for inspecting the results of system(). For the moment,
> > * hard-wire the check on Windows.
> > */
> > - #ifndef WIN32
> > if (!WIFEXITED(r) || WEXITSTATUS(r) > 1)
> > - #else
> > - if (r != 0 && r != 1)
> > - #endif
> > {
> > fprintf(stderr, _("diff command failed with status %d: %s\n"), r, cmd);
> > exit_nicely(2);
>
> Um, please also remove the comment just above that.
Done.
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2006-07-28 19:39:39 | Re: [Pgbuildfarm-members] [Fwd: RE: Build farm on Windows] |
| Previous Message | Tom Lane | 2006-07-28 19:29:47 | Re: [HACKERS] pg_regress breaks on msys |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-07-28 19:47:24 | Re: [HACKERS] 8.2 features? |
| Previous Message | Tom Lane | 2006-07-28 19:29:47 | Re: [HACKERS] pg_regress breaks on msys |