From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Robert Lor <Robert(dot)Lor(at)sun(dot)com> |
Subject: | Re: [PATCHES] Generic Monitoring Framework with DTrace patch |
Date: | 2006-07-21 12:00:53 |
Message-ID: | 20060721120053.GA21076@svana.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Fri, Jul 21, 2006 at 01:42:26PM +0200, Peter Eisentraut wrote:
> Robert Lor wrote:
> > I've have attached a patch along with two new files.This patch should
> > reflect what we discussed at the Summit. Please let me know if I miss
> > anything.
>
> I would prefer to drop the PG_ prefixes on PG_TRACE and pg_trace.h. We
> know which software we're dealing with.
I don't know. "trace" is a fairly generic word, how do you know that
none of the dozen other libraries we include don't already have a
"trace.h" or a TRACE() macro? On any of our supported platforms?
Debian already counts more than a dozen files called "trace.h". While
none are in libraries we're likely to use, this is just one platform.
If it were in a subdirectory (say utils/trace.h) that would be OK
too...
> > 1) The current logic in src/backend/Makefile will only work for
> > Solaris versions with DTrace, and Peter has offered to help fix this
> > one.
>
> We should probably move the probes file to a subdirectory. Anyone know
> a good place?
>
> Also, again, the pgsql prefix should be dropped.
The prefix here is redundant. We know which directory it's in.
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Trout | 2006-07-21 12:46:42 | Re: plPHP and plRuby |
Previous Message | Sandeep Jakkaraju(Navolve) | 2006-07-21 11:44:09 | Re: BF Failure on Bandicoot |
From | Date | Subject | |
---|---|---|---|
Next Message | Hannu Krosing | 2006-07-21 13:20:26 | Re: BF Failure on Bandicoot |
Previous Message | Sandeep Jakkaraju(Navolve) | 2006-07-21 11:44:09 | Re: BF Failure on Bandicoot |