| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] PQescapeIdentifier |
| Date: | 2006-07-04 13:23:01 |
| Message-ID: | 200607041323.k64DN1S07211@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> > Hang on a second. Has someone considered the encoding issues this might
> > suffer from, same as PQescapeString?
>
> That was the point I raised when I saw the commit.
>
> My advice is we shouldn't have PQescapeIdentifier at all.
> PQescapeIdentifierConn would be the thing to define,
> parallel to PQescapeStringConn.
Patch reverted, TODO updated to:
o Add PQescapeIdentifierConn()
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-07-04 13:31:46 | Re: system info functions |
| Previous Message | Zeugswetter Andreas DCP SD | 2006-07-04 12:53:54 | Re: update/insert, delete/insert efficiency WRT vacuum and |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-07-04 13:49:27 | Re: CREATE TRIGGER locking |
| Previous Message | Neil Conway | 2006-07-04 06:23:27 | CREATE TRIGGER locking |