From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, mha(at)sollentuna(dot)net, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Client build of MSVC6+ patch |
Date: | 2006-07-03 02:15:23 |
Message-ID: | 200607030215.k632FNu05028@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
I am thinking this patch needs to be applied, and the #ifdef test
changed to WIN32 so both MinGW and MSVC use the changed structure
ordering.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---------------------------------------------------------------------------
Hiroshi Saito wrote:
> Hi. Tom-san.
>
> Oops, I understood it. Thank you for suggestion.
> What condition is this?
>
> Regards,
> Hiroshi Saito
>
> From: "Tom Lane"
>
> > "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
> >>> Why do we need to reorder the fields in the struct?
> >
> >> Eh? Even my FreeBSD used well shows a structure object.
> >
> > The standard lists the fields in the other order:
> > http://www.opengroup.org/onlinepubs/009695399/basedefs/netdb.h.html
> >
> > Even though the standard doesn't say that that has to be the physical
> > order, every other platform besides Windows does it that way. The patch
> > as given is unacceptable because it *will* break other platforms (mine
> > for instance ;-)). If it has to be this way for Windows then we need
> > some sort of platform-specific #ifdef. Considering that the code works
> > as-is on several sorts of Windows builds, we probably need something
> > even more specific than that, like #if MSVC-before-version-XX.
> >
> > regards, tom lane
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-07-03 03:21:45 | Re: table/index fillfactor control, try 3 |
Previous Message | ITAGAKI Takahiro | 2006-07-03 01:56:02 | Re: table/index fillfactor control, try 3 |