Re: note about syntax for fillfactor patch

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: note about syntax for fillfactor patch
Date: 2006-07-02 16:29:55
Message-ID: 200607021629.k62GTtw08912@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> The latter seems seriously grotty: it forces the user to remember an

Agreed.

> I propose that we change the syntax to be
>
> WITH OIDS
> | WITHOUT OIDS
> | WITH (definition)
> | /*EMPTY*/
>
> and say that if you want to specify both OIDS and another option you
> have to write "oids" or "oids=false" in the definition list.
>
> This gets rid of the hazard that someone might try to specify
> conflicting oids options in the hardwired part of the syntax and
> in the definition list, and lets the hardwired syntax be deprecated
> and perhaps someday removed.
>
> Any objections?

Sounds good.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-07-02 16:34:36 Re: ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)
Previous Message Agent M 2006-07-02 16:25:43 Re: different sort order in windows and linux version