| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Greg Stark <gsstark(at)mit(dot)edu> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: CREATE TABLE LIKE x INCLUDING CONSTRAINTS |
| Date: | 2006-06-27 03:44:24 |
| Message-ID: | 200606270344.k5R3iOc22608@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Patch applied. Thanks.
---------------------------------------------------------------------------
Greg Stark wrote:
>
> Fixed previous patch by calling change_varattnos_of_a_node() to fix up
> constraint expressions in case attribute positions don't line up.
>
> change_varattnos_of_a_node is in tablecmds.c for inherited tables so this
> means making it extern. I have a feeling it probably ought to move to some
> file of functions for manipulating Nodes but I couldn't really find an
> appropriate place. At first I was going to put it in ruleutils.c but then it
> seems the other functions in that file go in builtins.h which would be a
> strange place for this I think.
>
> So in the end I left the functions in tablecmds.[ch] at least until someone
> more familiar with the source tree suggests another pair of files for them to
> be defined in.
>
[ Attachment, skipping... ]
>
> --
> greg
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zeugswetter Andreas DCP SD | 2006-06-27 08:04:25 | Re: [PATCHES] Non-transactional pg_class, try 2 |
| Previous Message | Tom Lane | 2006-06-27 03:37:30 | Re: [HACKERS] PQescapeIdentifier |