Re: pg_backup_tar.c seems anerror by win32

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_backup_tar.c seems anerror by win32
Date: 2006-06-27 02:56:52
Message-ID: 200606270256.k5R2uqU09329@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Hiroshi Saito wrote:
> Hi Bruce-san.
>
> Yesterday patch was inadequate....
>
> pg_backup_tar.c: In function `tarOpen':
> pg_backup_tar.c:379: `S_IREAD' undeclared (first use in this function)
> pg_backup_tar.c:379: (Each undeclared identifier is reported only once
> pg_backup_tar.c:379: for each function it appears in.)
> pg_backup_tar.c:379: `S_IWRITE' undeclared (first use in this function)
> pg_backup_tar.c: In function `_tarAddFile':
> pg_backup_tar.c:1051: warning: comparison is always false due to limited range of data type
> make[3]: *** [pg_backup_tar.o] Error 1
> make[2]: *** [all] Error 2
> make[1]: *** [all] Error 2
> make: *** [all] Error 2
>
> This patch helps this.
> Thanks.

Thanks. Patch applied to HEAD and 8.1.X.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-06-27 03:22:58 Re: Patch for BUG #2073: Can't drop sequence when created
Previous Message Bruce Momjian 2006-06-27 02:49:30 Re: [HACKERS] PQescapeIdentifier