From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
Subject: | table/index fillfactor control, try 3 |
Date: | 2006-06-22 05:58:52 |
Message-ID: | 20060622142927.5220.ITAGAKI.TAKAHIRO@oss.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
This is the 3rd revised fillfactor patch.
Now, AM specific options are stored in pg_class.reloptions as text[].
Also, some bugs are fixed. It passed all regression tests.
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> An opaque bytea won't do though. What I'd suggest is something real
> close to the format used for GUC parameters in ALTER DATABASE SET and
> ALTER USER SET, ie, pairs of keyword/value strings. This way pg_dump
> doesn't need very much smarts about what the values are that it's
> dumping.
The column format of options is changed from bytea to an array of text,
so re-parsing is needed every time a connection accesses a relation.
I changed to write pre-parsed options into pg_internal.init, but AFAICS,
only system relations are written in it. If we will find the parsing
is slow, it might be good to store options for user relations, too.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
fillfactor-0622.patch.gz | application/octet-stream | 33.9 KB |
fillfactor-0622.sql | application/octet-stream | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Marc G. Fournier | 2006-06-22 06:31:15 | Re: let's meet |
Previous Message | Qingqing Zhou | 2006-06-22 04:40:58 | Re: Problem to "current-status information in shared memory" patch |
From | Date | Subject | |
---|---|---|---|
Next Message | Hiroshi Saito | 2006-06-22 13:37:28 | MS-VC build patch |
Previous Message | Bruce Momjian | 2006-06-22 02:13:03 | Re: Overhead for stats_command_string et al, take 2 |