Re: longjmp in psql considered harmful

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: longjmp in psql considered harmful
Date: 2006-06-11 19:21:43
Message-ID: 20060611192143.GB4678@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Martijn van Oosterhout wrote:
> On Sun, Jun 11, 2006 at 02:57:38PM -0400, Tom Lane wrote:
> > Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> > > As it states in the comment, you can't remove the longjump because
> > > it's the only way to break out of the read() call when using BSD signal
> > > semantics (unless you're proposing non-blocking read+select()). So the
> > > patch sets up the sigjump just before the read() and allows the routine
> > > to return. If you're not waiting for read(), no sigjump is done.
> >
> > I think you're missing my point, which is: do we need control-C to
> > force a break out of that fgets at all?
>
> If you're asking me, yes. I use it a lot and would miss it if it were
> gone. Is there another shortcut for "abort current command and don't
> store in history but don't clear it from the screen"?

M-# (Note that it doesn't work in psql because it puts a # and not a
--. But we could fix it.)

But it does store in history. Why do you want it on the screen but not
in the history?

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-06-11 19:23:50 Re: longjmp in psql considered harmful
Previous Message Martijn van Oosterhout 2006-06-11 19:19:35 Re: longjmp in psql considered harmful