pgsql: Fix bootstrap.c so that database startup process and bgwriter

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix bootstrap.c so that database startup process and bgwriter
Date: 2006-06-08 23:55:48
Message-ID: 20060608235548.D34569FA5C3@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix bootstrap.c so that database startup process and bgwriter properly release
LWLocks during a panic exit. This avoids the possible self-deadlock pointed
out by Qingqing Zhou. Also, I noted that an error during LoadFreeSpaceMap()
or BuildFlatFiles() would result in exit(0) which would leave the postmaster
thinking all is well. Added a critical section to ensure such errors don't
allow startup to proceed.

Backpatched to 8.1. The 8.0 code is a bit different and I'm not sure if the
problem exists there; given we've not seen this reported from the field, I'm
going to be conservative about backpatching any further.

Modified Files:
--------------
pgsql/src/backend/bootstrap:
bootstrap.c (r1.215 -> r1.216)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/bootstrap.c.diff?r1=1.215&r2=1.216)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-06-08 23:55:55 pgsql: Fix bootstrap.c so that database startup process and bgwriter
Previous Message David Fetter 2006-06-08 23:21:05 Re: pgsql: Update wording: < * Add SQL99 WITH RECURSIVE to SELECT > * Add