Re: [HACKERS] Win32 sysconfig -> pg_service.conf

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, David Fetter <david(at)fetter(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Win32 sysconfig -> pg_service.conf
Date: 2006-06-07 03:22:51
Message-ID: 200606070322.k573MpB27296@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > On Win32, patch applied to return path if GetShortPathName() fails (no
> > short name, path does not exist), rather than returning nothing.
>
> Hm, are you sure GetShortPathName will never modify the path before
> failing? For instance, I'd be a bit worried about cases where it
> successfully adjusts some components of the path before finding one that
> doesn't exist.

Good point. Would someone test that? Is GetFullPathName() the proper
direction?

--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2006-06-07 03:35:19 DROP INHERITS
Previous Message Mark Woodward 2006-06-07 03:11:40 Re: How to avoid transaction ID wrap

Browse pgsql-patches by date

  From Date Subject
Next Message Jaime Casanova 2006-06-07 06:00:45 Re: fori stmt with by keyword was:(Re: [HACKERS] for statement,
Previous Message Bruce Momjian 2006-06-07 03:22:10 Re: [HACKERS] Win32 sysconfig -> pg_service.conf