Re: trivial fix in fd.c

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: trivial fix in fd.c
Date: 2006-05-30 13:04:53
Message-ID: 200605301304.k4UD4rP02783@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Patch applied. Thanks.

---------------------------------------------------------------------------

Qingqing Zhou wrote:
> Fix a format warning in fd.c when FDDEBUG is on.
>
> By the way (to save a thread): What's the rationale of designing resowner
> APIs like this:
>
> ResourceOwnerEnlargeABC();
> ResourceOwnerRememberABC();
>
> Is that because sometimes we don't allow any elog in
> ResourceOwnerRememberABC()?
>
> Regards,
> Qingqing
>
>
> Index: fd.c
> ===================================================================
> RCS file: /projects/cvsroot/pgsql/src/backend/storage/file/fd.c,v
> retrieving revision 1.127
> diff -c -r1.127 fd.c
> *** fd.c 5 Mar 2006 15:58:37 -0000 1.127
> --- fd.c 22 May 2006 08:00:42 -0000
> ***************
> *** 649,655 ****
> Index i;
> File file;
>
> ! DO_DB(elog(LOG, "AllocateVfd. Size %d", SizeVfdCache));
>
> Assert(SizeVfdCache > 0); /* InitFileAccess not called? */
>
> --- 649,655 ----
> Index i;
> File file;
>
> ! DO_DB(elog(LOG, "AllocateVfd. Size %lu", SizeVfdCache));
>
> Assert(SizeVfdCache > 0); /* InitFileAccess not called? */
>
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org
>

--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-05-30 13:30:13 Re: archiver.pid
Previous Message Bruce Momjian 2006-05-30 13:02:19 Re: Add namespace dependency for conversions