From: | "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com> |
---|---|
To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
Cc: | pgsql-patches(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com> |
Subject: | Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling |
Date: | 2006-05-11 23:37:03 |
Message-ID: | 20060511233703.GB4268@pervasive.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Tue, May 09, 2006 at 10:37:04PM +0200, Martijn van Oosterhout wrote:
> Note that the resulting times still include the overhead actually
> incurred, I didn't filter it out. I want the times to remain reflecting
> reality as closely as possible.
If we actually know the overhead I think it'd be very useful at times to
be able to remove it, especially if you're actually trying to compare to
the planner estimates. Maybe worth adding an option to the command?
> - I also didn't make it optional. I'm unsure about whether it should be
> optional or not, given the number of cases where it will make a
> difference to be very few.
The real question is how important it is to have the real data in the
cases where it would make a difference, and I suspect we can't answer
that until this is out in the field. It *might* be worth a #define or
some other way to disable it that doesn't require patching code, but
probably not.
--
Jim C. Nasby, Sr. Engineering Consultant jnasby(at)pervasive(dot)com
Pervasive Software http://pervasive.com work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf cell: 512-569-9461
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-05-12 03:58:04 | Continuing "pgstat update timeout" failures in buildfarm |
Previous Message | Jim C. Nasby | 2006-05-11 22:58:42 | Re: [HACKERS] Big IN() clauses etc : feature proposal |
From | Date | Subject | |
---|---|---|---|
Next Message | Mario Weilguni | 2006-05-12 07:16:44 | Re: BEGIN inside transaction should be an error |
Previous Message | Jim C. Nasby | 2006-05-11 23:15:33 | Re: Have configure complain about unknown options |