| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Peter(dot)Brant(at)wicourts(dot)gov |
| Subject: | Re: [HACKERS] Question on win32 semaphore simulation |
| Date: | 2006-05-08 02:39:52 |
| Message-ID: | 200605080239.k482dqq26081@candle.pha.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > While we have installed a Win32-specific semaphore implementation for
> > CVS HEAD, what do we want do apply for the back branches, 8.0.X and
> > 8.1.X. Is this the patch that should be applied?
>
> Leave 'em alone. That code has zero field validation, and should
> certainly not get shipped until it's survived a beta-test cycle.
Uh, this is a bug fix, and the patch I am asking about is not the Win32
semaphore reimplementation but a more limited fix. Here is the problem
report:
http://archives.postgresql.org/pgsql-bugs/2006-04/msg00101.php
The test request:
http://archives.postgresql.org/pgsql-bugs/2006-04/msg00251.php
and the successful test run:
http://archives.postgresql.org/pgsql-bugs/2006-05/msg00002.php
We don't require bug fixes to go through beta testing.
--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Martijn van Oosterhout | 2006-05-08 14:13:45 | Re: [PATCH] Magic block for modules |
| Previous Message | Tom Lane | 2006-05-08 00:21:43 | Re: [PATCH] Magic block for modules |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2006-05-08 02:54:27 | [WIP] The relminxid addition, try 3 |
| Previous Message | Bruce Momjian | 2006-05-08 02:20:17 | Re: pgstat: remove delayed destroy / pipe: |