Re: [COMMITTERS] pgsql: Don't try to compile SSL CRL support if local

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kris Jurka <books(at)ejurka(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Don't try to compile SSL CRL support if local
Date: 2006-05-05 18:28:13
Message-ID: 200605051828.k45ISDA10176@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-patches

Tom Lane wrote:
> Kris Jurka <books(at)ejurka(dot)com> writes:
> > On Thu, 4 May 2006, Tom Lane wrote:
> >> Don't try to compile SSL CRL support if local SSL installation hasn't
> >> got it. Per buildfarm failure on 'canary'.
>
> > It seems a little bit dangerous to just not check the CRL without so much
> > as a warning message.
>
> [ shrug... ] Anyone who's running openssl 0.9.6, or whatever that is on
> canary, isn't expecting CRL support anyway. And all I did is restore
> the behavior we've had for lo these past many years.

The problem is that we now document that we support CRL, so either we
log if we skip it, or we have to document which versions of OpenSSL do
not support CRL (yuck).

The attached patch checks for the file, and either user it or generates
a log message that it was skipped.

--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
unknown_filename text/plain 1.8 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-05-05 18:41:47 Re: [COMMITTERS] pgsql: Don't try to compile SSL CRL support if local
Previous Message Bruce Momjian 2006-05-05 18:10:35 pgsql: Seems some NetBSD 3.0 x86 systems still need

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-05-05 18:29:03 Re: [PATCHES] Adminpack contrib module
Previous Message Martijn van Oosterhout 2006-05-05 18:07:06 Re: Have configure complain about unknown options