From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Neil Conway <neilc(at)samurai(dot)com> |
Cc: | "P(dot) Scott DeVos" <scott(at)countrysidetechnology(dot)com>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: plpython tracebacks |
Date: | 2006-04-28 20:01:50 |
Message-ID: | 200604282001.k3SK1ok08403@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Neil, where are we on this patch?
---------------------------------------------------------------------------
Neil Conway wrote:
> P. Scott DeVos wrote:
> > I'm on it.
>
> Actually, don't worry about it -- I've made the corrections I had in
> mind myself. Attached is a revised patch. On looking closer, I didn't
> really like the way the patch accumulated the lines of the traceback:
> AFAICS _PyString_Join() is not an "official" Python C API function (it's
> not documented, at any rate), and besides it is cleaner and more
> efficient to build up the traceback string in a StringInfo rather than
> using Python lists and strings.
>
> The attached patch isn't quite finished: "No Traceback" when there is no
> traceback information doesn't seem like the best message, I need to
> update the regression tests and some comments, etc. But I plan to apply
> something similar in substance to the attached patch to HEAD in the next
> day or two, barring objections.
>
> -Neil
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Theo Schlossnagle | 2006-04-28 20:33:24 | Re: Solaris ASM problem |
Previous Message | Bruce Momjian | 2006-04-28 19:03:01 | Solaris ASM problem |