Re: pg_ctl options checking

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: pg_ctl options checking
Date: 2006-04-17 19:01:46
Message-ID: 200604172101.47048.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian wrote:
> Peter Eisentraut wrote:
> > Simon Riggs wrote:
> > > pg_ctl -D test -U foo start
> > > pg_ctl -D test -W start
> > > pg_ctl -D test -w stop
> > > pg_ctl -D test -l fast stop
> > > etc.. (16 possible error combinations in total now checked)
> >
> > I object to making these throw an error. It is very convenient to
> > be able to alter the command line from start to stop to reload etc.
> > without having to remove or rewrite all the options that are not
> > really relevant for that particular operation.
>
> For a command as significant as pg_ctl, I can't see how making it
> _convenient_ is a good argument.

Well, loss of convenience is one argument in opposition to this change
but I don't see any argument in _favor_ of this change other than
"let's reject these option combinations", some of which seem perfectly
valid.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-04-17 19:04:39 Re: pg_ctl options checking
Previous Message Bruce Momjian 2006-04-17 18:11:16 Re: pg_ctl options checking