pgsql: Comments in IndexBuildHeapScan describe the indexing of

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Comments in IndexBuildHeapScan describe the indexing of
Date: 2006-03-24 23:02:18
Message-ID: 20060324230218.2F5EF9DC8AF@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Comments in IndexBuildHeapScan describe the indexing of recently-dead
tuples as needed "to keep VACUUM from complaining", but actually there is
a more compelling reason to do it: failure to do so violates MVCC semantics.
This is because a pre-existing serializable transaction might try to use
the index after we finish (re)building it, and it might fail to find tuples
it should be able to see. We got this mostly right, but not in the case
of partial indexes: the code mistakenly discarded recently-dead tuples for
partial indexes. Fix that, and adjust the comments.

Modified Files:
--------------
pgsql/src/backend/catalog:
index.c (r1.263 -> r1.264)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/index.c.diff?r1=1.263&r2=1.264)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-03-24 23:02:23 pgsql: Comments in IndexBuildHeapScan describe the indexing of
Previous Message User Aparashar 2006-03-24 22:53:48 bizgres - bizgres: Includes: 1.