From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Krb5 & multiple DB connections |
Date: | 2006-03-06 17:59:37 |
Message-ID: | 200603061759.k26HxbF27724@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Patch applied. Thanks.
Backpatched to 8.1.X.
---------------------------------------------------------------------------
Stephen Frost wrote:
> Greetings,
>
> * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> > I've now tested this patch at home w/ 8.2HEAD and it seems to fix the
> > bug. I plan on testing it under 8.1.2 at work tommorow with
> > mod_auth_krb5, etc, and expect it'll work there. Assuming all goes
> > well and unless someone objects I'll forward the patch to -patches.
> > It'd be great to have this fixed as it'll allow us to use Kerberos to
> > authenticate to phppgadmin and other web-based tools which use
> > Postgres.
>
> While playing with this patch under 8.1.2 at home I discovered a
> mistake in how I manually applied one of the hunks to fe-auth.c.
> Basically, the base code had changed and so the patch needed to be
> modified slightly. This is because the code no longer either has a
> freeable pointer under 'name' or has 'name' as NULL.
>
> The attached patch correctly frees the string from pg_krb5_authname
> (where it had been strdup'd) if and only if pg_krb5_authname returned
> a string (as opposed to falling through and having name be set using
> name = pw->name;). Also added a comment to this effect.
> Please review.
>
> Thanks,
>
> Stephen
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend
--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Markus Bertheau | 2006-03-06 18:01:57 | Re: pg.conf re-reading in signal handler or at next return to main loop? |
Previous Message | Neil Conway | 2006-03-06 17:59:20 | Re: Coverity Open Source Defect Scan of PostgreSQL |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2006-03-06 19:03:45 | Re: TODO item: remove postmaster -o option |
Previous Message | Bruce Momjian | 2006-03-06 17:41:15 | Re: LDAP auth |