| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ipcclean in 8.1 broken? |
| Date: | 2006-03-03 18:00:59 |
| Message-ID: | 200603031800.k23I0xI14776@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Chris said he did:
> >> Well all I did to fix it on FreeBSD was to remove the '-o "$LOGNAME" =
> >> 'root'' bit...
> > so I figured the patch would help, no?
>
> No, because there's no good reason to suppose that $USER wouldn't be set.
But if USER is set, why check LOGNAME?
> I think we should remove that entire code block, and instead check for a
> zero value of EffectiveUser after doing the id bit.
>
> (I'm not finding it right now, but I'm pretty sure that the SUS
> specifies that numeric userid == 0 for superuser, whereas "root" is not
> required to be the name, so this would be more correct anyway.)
Can we assume 'id' is on all unix systems?
--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephan Szabo | 2006-03-03 18:13:51 | Re: Foreign keys for non-default datatypes |
| Previous Message | Tom Lane | 2006-03-03 17:49:29 | Re: ipcclean in 8.1 broken? |