Re: ipcclean in 8.1 broken?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ipcclean in 8.1 broken?
Date: 2006-03-03 17:24:26
Message-ID: 200603031724.k23HOQh08575@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I applied the attached patch to CVS HEAD and 8.1.X. It looks at LOGNAME
> > only if USER is not set.
>
> > ! if [ "$USER" = 'root' -o "$LOGNAME" = 'root' ]
>
> > ! # only check $LOGNAME if $USER is not set
> > ! if [ "$USER" = 'root' -o \( ! "$USER" -a "$LOGNAME" = 'root' \) ]
>
> Bruce, this patch isn't going to fix anything.

Chris said he did:

> Well all I did to fix it on FreeBSD was to remove the '-o "$LOGNAME" =
> 'root'' bit...

so I figured the patch would help, no?

--
Bruce Momjian http://candle.pha.pa.us
SRA OSS, Inc. http://www.sraoss.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Csaba Nagy 2006-03-03 17:27:33 Re: Automatic free space map filling
Previous Message Tom Lane 2006-03-03 17:21:31 Re: ipcclean in 8.1 broken?