Re: [GENERAL] Number format problem

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Daniel Verite <daniel(at)manitou-mail(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [GENERAL] Number format problem
Date: 2006-02-13 02:58:50
Message-ID: 200602130258.k1D2wo209084@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-patches

Daniel Verite wrote:
> Bruce Momjian wrote:
>
> > > > Oh, so C locale has "" for thousands_sep? Hmm. So there is no way to
> > > > disinguish "" as "don't have" from "" as "don't want". Will revert.
> > >
> > > Possibly we could special-case C locale, and allow an empty string only
> > > when not C locale. However, it could be that there are other locales
> > > where the change would surprise people, too :-(
> >
> > Not sure. Peter stated the French locale was wrong for the Debian they
> > were using, and he should know, so I am going to wait for more feeback.
>
> The baseline glibc sources from gnu.org have
> (in glibc-2.3.6/localedata/locales/fr_FR):
>
> LC_NUMERIC
> decimal_point "<U002C>"
> thousands_sep ""
> grouping 0;0
> END LC_NUMERIC
>
> So at first sight it's more a glibc issue rather than debian-specific.
>
> However, this was filed as a bug in debian long ago. Incidentally, it got fixed
> just this week, meaning that the future debian-glibc should use a space instead
> of the empty string, as reported here:
> http://lists.debian.org/debian-glibc/2006/02/msg00168.html
> Which is consistent with Peter's statement that it was wrong up to now, and also
> with what the OP expected in the first place.

Oh, good. I looked and now realize that psql is already checking for a
non-"" string:

if (*extlconv->thousands_sep)

so we are consistent.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Michael Glaesemann 2006-02-13 03:05:34 Re: dumb question
Previous Message Craig White 2006-02-13 02:47:11 Re: dumb question

Browse pgsql-patches by date

  From Date Subject
Next Message Sergey E. Koposov 2006-02-13 12:31:09 patch correcting the build failure on machines without readline
Previous Message Bruce Momjian 2006-02-13 02:49:30 Re: Free WAL caches on switching segments