From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kris Jurka <books(at)ejurka(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Allow psql multi-line column values |
Date: | 2006-02-10 16:59:58 |
Message-ID: | 200602101659.k1AGxw923619@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-patches |
Martijn van Oosterhout wrote:
-- Start of PGP signed section.
> On Fri, Feb 10, 2006 at 11:02:41AM -0500, Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > OK, I have applied your patch to psql and Teodor has adjusted the
> > > tsearch2 expected results. I can't seem to run pgcrypto without getting
> > > PRNG errors, so I expect my SSL is too old. Would you send me your
> > > pgcrypto/regression.diff? Thanks.
> >
> > I fixed that already. Please see about fixing the compiler warnings you
> > introduced. On a 64-bit machine there are even more, and the int vs
> > size_t ones are definitely portability problems.
>
> Ouch. I submitted this patch so long ago I figured it'd gotten lost. I
> was actually considering preparing a new version against HEAD.
We loose nothing! :-)
> I'll try to address these warnings (unless someone beats me to it).
I am looking at it now but I can't find the compiler flag to get those
warnings. I am gcc 2.95.3.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-02-10 17:06:10 | Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align |
Previous Message | Martijn van Oosterhout | 2006-02-10 16:58:12 | Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-02-10 17:06:10 | Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align |
Previous Message | Tom Lane | 2006-02-10 16:58:33 | Re: Scrollable cursors and Sort performance |