From: | Joachim Wieland <joe(at)mcknight(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: psql tab completion enhancements |
Date: | 2006-02-03 21:41:38 |
Message-ID: | 20060203214138.GA5459@mcknight.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
On Fri, Feb 03, 2006 at 04:15:32PM -0500, Tom Lane wrote:
> > - Should all the
> > const char* foocompletion = { "BAR", "BAZ" };
> > be changed to
> > char* foocompletion = { "BAR", "BAZ" };
> Removing const decoration sure seems like the wrong direction to be
> going in. Why can't you still have const on the functions that expect
> to take non-modifiable lists?
ok, one could duplicate the functionality of complete_from_list() and add a
function complete_from_malloced_list() or similar (or refactor both such that
they call a third function that does the actual work - if possible). I will
do that if this is what you're proposing.
Joachim
From | Date | Subject | |
---|---|---|---|
Next Message | Joachim Wieland | 2006-02-04 00:29:24 | Re: psql tab completion enhancements |
Previous Message | Tom Lane | 2006-02-03 21:15:32 | Re: psql tab completion enhancements |