From: | tgl(at)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Repair longstanding bug in slru/clog logic: it is possible for |
Date: | 2006-01-21 04:38:21 |
Message-ID: | 20060121043821.9F22A9DCB5D@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Repair longstanding bug in slru/clog logic: it is possible for two backends
to try to create a log segment file concurrently, but the code erroneously
specified O_EXCL to open(), resulting in a needless failure. Before 7.4,
it was even a PANIC condition :-(. Correct code is actually simpler than
what we had, because we can just say O_CREAT to start with and not need a
second open() call. I believe this accounts for several recent reports of
hard-to-reproduce "could not create file ...: File exists" errors in both
pg_clog and pg_subtrans.
Modified Files:
--------------
pgsql/src/backend/access/transam:
slru.c (r1.33 -> r1.34)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/slru.c.diff?r1=1.33&r2=1.34)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-01-21 04:38:27 | pgsql: Repair longstanding bug in slru/clog logic: it is possible for |
Previous Message | Bruce Momjian | 2006-01-21 02:16:21 | pgsql: Add GRANT ON SEQUENCE syntax to support sequence-only |