pgsql: Fix pg_tzset() to ensure that 'lclmem' (the static variable

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_tzset() to ensure that 'lclmem' (the static variable
Date: 2006-01-10 20:16:25
Message-ID: 20060110201625.6D0BD9DC8D9@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix pg_tzset() to ensure that 'lclmem' (the static variable holding
the localtime timezone data) is not overwritten until we know the data
is good. tzload() is capable of failing after having begun modifying
the struct it's pointed at, and in such cases the static data was left
in a corrupt state. Bug does not exist pre-8.0 (since we didn't have
this code then) nor post-8.0 (since we already changed the code to
tzload into local variables initially). Per report from Nick Martens.

Tags:
----
REL8_0_STABLE

Modified Files:
--------------
pgsql/src/timezone:
localtime.c (r1.9 -> r1.9.4.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/timezone/localtime.c.diff?r1=1.9&r2=1.9.4.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-01-10 21:59:59 pgsql: Improve error messages for missing-FROM-entry cases, as per
Previous Message Neil Conway 2006-01-10 18:50:44 pgsql: Minor code clarity improvement: AFAICS, estate.eval_econtext must