Re: BUG #17886: Error disabling user triggers on a partitioned table

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: jazz001319(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17886: Error disabling user triggers on a partitioned table
Date: 2023-04-05 16:57:29
Message-ID: 2005410.1680713849@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2023-Apr-04, Tom Lane wrote:
>> I'm inclined to think that in the older branches (pre f4566345c)
>> we need to do
>> - if (oldtrig->tgisinternal)
>> + if (oldtrig->tgisinternal && !OidIsValid(oldtrig->tgparentid))
>> but I've not tested that. Alvaro, what do you think?

> Oh, that's a nice and clean solution. I tested it (on 13 and 14) and it
> does solve the problem, and no regression tests fail, but I didn't try
> to break it further. 12 and back are unaffected, for lack of
> 86f575948c77.

Pushed, thanks for looking at it.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2023-04-05 17:32:26 BUG #17887: EDB Community Installer for windows, locale selection not working properly
Previous Message Mats Kindahl 2023-04-05 07:58:27 Re: BUG #17876: Function width_bucket() for float8 input returns value out of range