From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)hotmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: I can't get row type from tuple (SPI) |
Date: | 2005-12-04 04:14:51 |
Message-ID: | 200512040414.jB44Epq10958@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Added to TODO:
* Add SPI_gettypmod() to return the typemod for a TupleDesc
---------------------------------------------------------------------------
Tom Lane wrote:
> "Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com> writes:
> > rettupdesc = lookup_rowtype_tupdesc(rettype,0);
>
> This is wrong --- if you don't know what typmod to use, *always* pass -1
> not 0. (I suspect that rettype is RECORD and that -1 would have
> resulted in a NULL result.)
>
> It seems like SPI is missing a needed function: it should have an
> SPI_gettypmod to go along with SPI_gettypeid. This would probably
> give you the correct typmod to pass to lookup_rowtype_tupdesc here.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-12-04 04:33:31 | Re: pg_restore [archiver] file offset in dump file is too |
Previous Message | Tom Lane | 2005-12-04 04:05:23 | Re: [PATCHES] snprintf() argument reordering not working under |