From: | ishii(at)postgresql(dot)org (Tatsuo Ishii) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Two fixes from Tom Lan. |
Date: | 2005-12-04 01:22:43 |
Message-ID: | 20051204012243.69DFB9DCC3F@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Two fixes from Tom Lan. See the posting "[PATCHES] A couple of
proposed pgbench changes" on 2005/11/29 for more details.
The change at line 490 updates doCustom's local variable "commands"
after selecting a new file (command sequence). I think that the
existing coding will cause the thing to use the first command of the
old sequence in the remainder of the routine, which would be a bug.
I have not tried to set up a test case to prove it, though.
The other two changes cause doCustom to loop after processing a
meta-command. This might be a bit controversial, but as the code
is currently written, each meta-command "costs" one cycle of the
outer select() loop. Thus, for example, with the default TPC-B script,
once a backend returns "COMMIT" it will not receive a new command
until four cycles of issuing commands to other backends have elapsed.
(You can see this very easily by strace'ing pgbench under load.)
Tags:
----
REL8_1_STABLE
Modified Files:
--------------
pgsql/contrib/pgbench:
pgbench.c (r1.45.2.2 -> r1.45.2.3)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pgbench/pgbench.c.diff?r1=1.45.2.2&r2=1.45.2.3)
From | Date | Subject | |
---|---|---|---|
Next Message | James William Pye | 2005-12-04 03:26:18 | python - be: Use regprocedurein for string based function lookups. |
Previous Message | James William Pye | 2005-12-04 00:31:37 | python - be: Update the prototype. |