Re: [HACKERS] Should libedit be preferred to libreadline?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: Zeugswetter Andreas DCP SD <ZeugswetterA(at)spardat(dot)at>, Seneca Cunningham <scunning(at)ca(dot)afilias(dot)info>, pgsql-hackers(at)postgresql(dot)org, pgsql-ports(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Date: 2005-11-25 17:02:04
Message-ID: 200511251702.jAPH24004546@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches pgsql-ports

Martijn van Oosterhout wrote:
-- Start of PGP signed section.
> On Tue, Nov 22, 2005 at 10:07:15AM +0100, Zeugswetter Andreas DCP SD wrote:
> > PS: I'd prefer if readline was only linked where it is needed, namely in
> > psql.
>
> The problem as stated is that people don't want to maintain lists of
> libraries as needed by each program, so we link all of them.
>
> Since it seems to always be the same few libraries that cause us
> problems, maybe a simpler approach would be to, in the Makefile, use
> filter-out to exclude libraries you *know* aren't needed. Like in the
> Makefile we put:
>
> postgres: $(OBJS)
> $(CC) $(CFLAGS) $(LDFLAGS) $(export_dynamic) $^ $(filter-out -lreadline -ledit, $(LIBS)) -o $@

Agreed. I have no idea why this has not been done already.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-11-25 17:04:12 Re: [HACKERS] Should libedit be preferred to libreadline?
Previous Message Peter Eisentraut 2005-11-25 16:37:00 Re: PL/php in pg_pltemplate

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-11-25 17:04:12 Re: [HACKERS] Should libedit be preferred to libreadline?
Previous Message Martijn van Oosterhout 2005-11-25 16:54:17 Re: [PATCH] Formatting patch for psql

Browse pgsql-ports by date

  From Date Subject
Next Message Bruce Momjian 2005-11-25 17:04:12 Re: [HACKERS] Should libedit be preferred to libreadline?
Previous Message Jim C. Nasby 2005-11-22 20:49:24 Re: [HACKERS] Should libedit be preferred to libreadline?