Re: A few pgindent oddities

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: A few pgindent oddities
Date: 2005-11-23 00:34:57
Message-ID: 200511230034.jAN0YvL14618@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> > And what happened here?
>
> I saw this one to and was stumped at the cause. We have other 'typedef
> enum' lines in the code which were not mangled, just this one. Again,
> needs research.
>
> > Index: src/interfaces/libpq/libpq-fe.h
> > ***************
> > *** 35,41 ****
> >
> > /* Application-visible enum types */
> >
> > ! typedef enum
> > {
> > /*
> > * Although it is okay to add to this list, values which become unused
> > --- 35,41 ----
> >
> > /* Application-visible enum types */
> >
> > ! typedef enum
> > {
> > /*
> > * Although it is okay to add to this list, values which become unused

Ah the cause of this one is this at the top of src/interfaces/libpq/libpq-fe.h:

#ifdef __cplusplus
extern "C"
{
#endif

Not sure I can blame pgindent. Of course the fact that the other
'typedef enum' lines in the file are not indented isn't consistent.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2005-11-23 00:41:14 Re: tablespaces and non-empty directories
Previous Message Bruce Momjian 2005-11-23 00:28:54 Re: A few pgindent oddities