pgsql: Change array_push and array_cat so that they retain the lower

From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Change array_push and array_cat so that they retain the lower
Date: 2005-11-19 01:50:09
Message-ID: 20051119015009.27BACDBB53@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Change array_push and array_cat so that they retain the lower bound of
the array (for array_push) or higher-dimensional array (for array_cat)
rather than decrementing it as before. This avoids generating lower
bounds other than one for any array operation within the SQL spec. Per
recent discussion.
Interestingly, this seems to have been the original behavior, because
while updating the docs I noticed that a large fraction of relevant
examples were *wrong* for the old behavior and are now right. Is it
worth correcting this in the back-branch docs?

Modified Files:
--------------
pgsql/doc/src/sgml:
array.sgml (r1.47 -> r1.48)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/array.sgml.diff?r1=1.47&r2=1.48)
func.sgml (r1.293 -> r1.294)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/func.sgml.diff?r1=1.293&r2=1.294)
pgsql/src/backend/utils/adt:
array_userfuncs.c (r1.17 -> r1.18)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/array_userfuncs.c.diff?r1=1.17&r2=1.18)
pgsql/src/test/regress/expected:
arrays.out (r1.27 -> r1.28)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/arrays.out.diff?r1=1.27&r2=1.28)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2005-11-19 02:08:45 pgsql: Add defenses against nulls-in-arrays to contrib/ltree.
Previous Message User Gsmet 2005-11-19 00:47:45 pgfouine - pgfouine: minor formatting improvements