| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <mha(at)sollentuna(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fixes for 8.1 run of pgindent |
| Date: | 2005-11-15 14:00:31 |
| Message-ID: | 200511151400.jAFE0VN21009@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Magnus Hagander wrote:
> > I think we should rerun pgindent on 8.1.X and HEAD to correct
> > the reported problems. I am betting 90% of our patches
> > either come from CVS head or 8.1.X branches greater than 8.1.0.
>
> Do we really want to run cosmetic cleanups on a stable branch?
>
> I'm sure it *should* be safe, it just seems "against the rules" :-)
Agreed, it is not a great idea, but if we don't, then 8.1.X and CVS HEAD
will not match indenting, and patches generated by 8.1.X users will not
apply cleanly to CVS HEAD. And if we don't run it at all, we then will
have CVS HEAD with columns > 80 and incorrect typedef indentations.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2005-11-15 14:05:00 | Re: Running PostGre on DVD |
| Previous Message | Dave Page | 2005-11-15 13:56:19 | Re: Running PostGre on DVD |