From: | tgl(at)svr1(dot)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Code review for regexp_replace patch. |
Date: | 2005-10-18 20:38:58 |
Message-ID: | 20051018203858.BFADDD97FE@svr1.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Code review for regexp_replace patch. Improve documentation and comments,
fix problems with replacement-string backslashes that aren't followed by
one of the expected characters, avoid giving the impression that
replace_text_regexp() is meant to be called directly as a SQL function,
etc.
Modified Files:
--------------
pgsql/doc/src/sgml:
func.sgml (r1.287 -> r1.288)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/func.sgml.diff?r1=1.287&r2=1.288)
pgsql/src/backend/utils/adt:
regexp.c (r1.59 -> r1.60)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/regexp.c.diff?r1=1.59&r2=1.60)
varlena.c (r1.137 -> r1.138)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/varlena.c.diff?r1=1.137&r2=1.138)
pgsql/src/include/utils:
builtins.h (r1.266 -> r1.267)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/builtins.h.diff?r1=1.266&r2=1.267)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-10-18 20:45:11 | Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors |
Previous Message | David Fetter | 2005-10-18 18:28:16 | Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors |